tests: kernel: device: add missing node in hifive board overlays #96100
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
force-pushed
the
fakedeferdriver
branch
from
3dc5395 to
052c5fa
Compare
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis,
TaiJuWu and
tbursztyka
peter-mitsis
previously approved these changes
Sep 16, 2025
|
ping @tbursztyka, this will help get less failures in weekly CI - thanks! |
ljd42
requested changes
Sep 19, 2025
A follow-up to commit d6ce2f4 that introduced a new fakedeferdriver node in app.overlay, but due to how overlays are applied, the board specific overlay files also need to be updated to avoid build errors, as they override whatever app.overlay has. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
fakedeferdriver
branch
from
052c5fa to
5827df6
Compare
|
ljd42
approved these changes
Sep 19, 2025
|
Changes is fine to fix the CI issues. In a longer run, we should refactor the overlays to have a "DRYer" solution. and avoid having to update overlays in multiple places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to commit d6ce2f4 that introduced a new fakedeferdriver node in app.overlay, but due to how overlays are applied, the board specific overlay files also need to be updated to avoid build errors, as they override whatever app.overlay has.
Fixes a few errors caught in weekly CI
cc @ljd42